[static] Remove some repeated env reads from pulumi code #1059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicu-da
commented
Jun 10, 2025
Contributor
Author
There was a problem hiding this comment.
sneaked this in as the new operator uses really low amount of resources
isegall-da
reviewed
Jun 10, 2025
cluster/pulumi/common/src/secrets.ts
Outdated
Contributor
There was a problem hiding this comment.
Why is this ok to read directly from env?
Contributor
Author
There was a problem hiding this comment.
It's really just used for:
(process.env['KUBECONFIG'] = kubecfg
so don't think it makes sense to read it from anywhere else?
Contributor
There was a problem hiding this comment.
Ahh right, the stupid absolute path thing...
nicu-da
force-pushed
the
nicuda/pulumi/remove_repeated_read
branch
from
8492dc4 to
2eae55a
Compare
Cleaning up the pulumi output for easier debugging Signed-off-by: Nicu Reut <nicu.reut@digitalasset.com>
nicu-da
force-pushed
the
nicuda/pulumi/remove_repeated_read
branch
from
2eae55a to
b7b5524
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up the pulumi output for easier debugging
eg of a single stack update
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines